-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xref to wildcard field type; correct URL for expensive-queries #9212
Conversation
Signed-off-by: Stavros Macrakis <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
I am confused by the expression "When you're ready for doc review, tag the assignee of this PR." According to chatgpt, I need to mention ("tag") @kolchfa-aws in a comment, who has already been "assigned" to this issue by github-actions (not to mention the 6 "pending reviewers"). But my pull request already "requested review". Is the idea that I submit the pull request before I think it is "technically accurate", then sleep on it, and submit it for review later? |
@smacrakis Thanks for tagging me! 😄 When you submit a PR (and it's not in the |
Signed-off-by: kolchfa-aws <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi, @kolchfa-aws -- I think you've explained this to me before. Sorry for the noise. I guess I just need to submit changes more often so I don't forget the procedure from one time to the next! |
Description
Mentions wildcard field type, which makes these queries more efficient.
Fix URL for expensive-queries
Issues Resolved
NA
Version
2.15 up
Frontend features
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.